intel / intel/confidential-computing.sgx

external/epid-sdk GroupId definition differs from upstream

Open
#418 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.5k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

As part of third-party code compliance review, I've been asked to change our build of linux-sgx to instead depend on more up-to-date and independently maintained packages.

The changelog for external/epid-sdk suggests it's v6.0.0, but the difference I see doesn't account for the history I see in https://github.com/Intel-EPID-SDK/epid-sdk.

Why do these definitions diverge?

--- third_party/linux_sgx/v_2_5/external/epid-sdk/epid/common/types.h
+++ third_party/epid_sdk/v6_0_1/epid/common/types.h
@@ -144,9 +144,7 @@
} Epid2Params;

/// group ID
-typedef OctStr32 GroupId;
-typedef OctStr32 RLver_t;
-typedef OctStr32 RLCount;
+typedef OctStr128 GroupId;

/// Intel(R) EPID 2.0 group public key
/*!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.