intel / intel/confidential-computing.sgx

use proper oal API in linux_network_service_bundle

Open
#1,085 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
1.5k
Forks
565
PR merge metrics
No merged PRs in 30d

Description

According to the way oal.h is used elsewhere in the repository (at 8e9ed532cc9b4dc4f86e6d2e1fef45e411892233), the intended API appears to be:
```
#include
```
I think this change is required, and the additional oal related include can be removed from `CMakeLists.txt`:
```patch
--- a/psw/ae/aesm_service/source/bundles/linux_network_service_bundle/aesm_http_msg.cpp
+++ b/psw/ae/aesm_service/source/bundles/linux_network_service_bundle/aesm_http_msg.cpp
@@ -32,7 +32,7 @@

#include
#include "aesm_encode.h"
-#include "oal.h"
+#include "oal/oal.h"
#include "se_wrapper.h"
#include "se_thread.h"
#include "prof_fun.h"
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.