intel / intel/confidential-computing.sgx.sdk
use proper linux-regs API in tsetjmp
Open
Beginner friendly
Nobody has claimed this yet.
bug
- Dominant language
- C++
- Stars
- 2
- Forks
- 3
- PR merge metrics
- No merged PRs in 30d
Description
According to the way linux-regs.h is used elsewhere in the repository (at 8e9ed53), the intended API appears to be:
#include <linux/linux-regs.h>
I think this change is required, and the additional internal/linux related include can be removed from Makefile:
--- linux-sgx-2.26.orig/sdk/tsetjmp/_setjmp.S
+++ linux-sgx-2.26/sdk/tsetjmp/_setjmp.S
@@ -34,7 +34,7 @@
* from: @(#)_setjmp.s 5.1 (Berkeley) 4/23/90
*/
.file "_setjmp.S"
-#include "linux-regs.h"
+#include <linux/linux-regs.h>
#if defined(LIBC_SCCS)
RCSID("$NetBSD: _setjmp.S,v 1.9 2014/05/23 02:34:19 uebayasi Exp $")
#endif
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with sdk/tsetjmp/_setjmp.S and compare its linux-regs.h usage with the example at commit 8e9ed53. Update the include to use the Linux API and inspect the Makefile for the additional internal/linux-related include. Done means the assembly file uses the intended header and the obsolete Makefile include is removed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- linux
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100