intel / intel/asynch_mode_nginx

Question about ssl_asynch on

Open
#91 3 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
225
Forks
69
PR merge metrics
No merged PRs in 30d

Description

Hi there,

When I was trying QAT SW (with async_mode_nginx v0.5.0), I found out that if I switched on `ssl_asynch`, it automatically switched `ssl` on. Is there any specific reason for this?
I also noticed that you removed this part of codes in v0.5.2:

```
/* If ssl_asynch on is configured, then ssl on is configured by default
* This will align 'ssl_asynch on;' and 'listen port ssl' diretives
* */
pssl = (ngx_flag_t *) ((char *)conf + offsetof(ngx_http_ssl_srv_conf_t, enable));
pssl_asynch = (ngx_flag_t *) ((char *)conf + cmd->offset);

if(*pssl_asynch && *pssl != 1) {
*pssl = *pssl_asynch;
}
```

Does this mean that I can now use my v0.5.0 and remove this logic without any other side effects?

Thank you very much.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.