intel / intel/FSP

ApolloLakeFspBinPkg[MR6] broken MPS with `PcieRpHotPlug = 1`

Open
#55 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
359
Forks
142
PR merge metrics
No merged PRs in 30d

Description

Enabling `PcieRpHotPlug` (or rather leaving it enabled) causes inconsistent MPS settings in the respective RPs:

* DCAP Max Payload Size Supported will be cleared to 0 (128B)
* DCTL Max Payload Size will be set to 1 (256B)

Whether or not the DCAP change is intentional is impossible to say. As usual there is no documentation about FSP. It's also possible that DCAP is written by accident (it's RW/O).
That DCTL is written at all is another issue.

Please issue a fixed binary or release the code to the public so we can work on a proper implementation (which would be much less expensive for Intel's hardware customers that are currently forced into beta testing your software).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.