intel / intel/FSP

Kabylake: FSP modifies AHCI/SATA capabilities

Open
#33 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
359
Forks
142
PR merge metrics
No merged PRs in 30d

Description

On Kabylake FSP sets CAP.SSS=0 when not at least one bit in SataPortsSpinUp is set. SataPortsSpinUp[x]=1 sets PxCMD.SUD=1.

Is there any reason FSP is disabling a CAP? IMHO it does not make any sense to make this dependent on SataPortsSpinUp, as the OS assumes the AHCI controller does not support this, then.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.