[RPL] Inconsistencies between default UPD values in FSP headers and BFS file
- Dominant language
- C
- Stars
- 359
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
The FSP headers are misleading about VrConfigEnable default state: https://github.com/intel/FSP/blob/master/RaptorLakeFspBinPkg/Client/RaptorLakeS/Include/FspsUpd.h#L1434
The comment bolds the default as disabled, but the real default is enabled for all domains per BSF: https://github.com/intel/FSP/blob/master/RaptorLakeFspBinPkg/Client/RaptorLakeS/Fsp.bsf#L1007
There might be more inconsistencies, which I haven't noticed, also in other platforms.
Contributor guide
Research direction
Start by comparing RaptorLakeFspBinPkg/Client/RaptorLakeS/Include/FspsUpd.h at line 1434 with RaptorLakeFspBinPkg/Client/RaptorLakeS/Fsp.bsf at line 1007, then inspect corresponding UPD defaults on other platforms. Done means the header comments and BSF defaults agree, including VrConfigEnable across all relevant domains, with any additional inconsistencies identified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c
- Domain
- embedded-iot
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100