integrations / integrations/terraform-provider-github

[MAINT]: Remove read call from create/update

Open
#2,892 0 comments 1 reaction 0 assignees View on GitHub
Type: Maintenance vNext
Dominant language
Go
Stars
1.2k
Forks
1k
Avg merge
1d 14h
Merged PRs (30d)
8

Description

### Describe the need

This provider make heavy use of calling the read function instead of duplicating logic in the create/update functions; while this may look clean and DRY it has a significant impact. Firstly it means that changes generally use twice as many API calls to make as they should (or more in cases where a single resource is mapped to multiple API calls); which is impactful given the low API rate limits imposed by GitHub. Secondly it means that systems which don't have strict read after write guarantees may be returning incorrect values to be stored in the state.

### SDK Version

_No response_

### API Version

_No response_

### Relevant log output

```shell

```

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.