integrations / integrations/terraform-provider-github

[FEAT]: treat equivalent permissions as equivalent (write == push)

Open
#2,446 2 comments 3 reactions 0 assignees View on GitHub
Status: Triage Type: Feature
Dominant language
Go
Stars
1.2k
Forks
1k
Avg merge
1d 14h
Merged PRs (30d)
8

Description

### Describe the need

In github_repository_collaborators, user and team permission "write" is silently translated to "push". So setting up a resource to grant write permission as in the Github UI works; it sets the push permission. But when checking the resource state, "push" is returned. That presents as a difference, resulting in always requiring a change.

It'd be nice to catch this hidden translation and either accept that push==write or emit a warning. I assume someone can't create a custom role called "write", and that if they did, they're evil incarnate. :imp:

### SDK Version

_No response_

### API Version

_No response_

### Relevant log output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.