intake / intake/intake-esm

Better abstraction for driver & file type handling

Open
#729 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
164
Forks
54
PR merge metrics
No merged PRs in 30d

Description

> Okay, think this is more or less ready to go.
>
> Stylistically I'm really not a fan of the if/else chain I've used to implement this, but I think it's going to be a bit of a pain to implement it 'more properly' - I'll open a separate PR doing so.
>
_Originally posted by @charles-turner-1 in https://github.com/intake/intake-esm/issues/728#issuecomment-3070879270_

TLDR; the `CatalogFileDataReader` in `cat.py` could do with a better abstraction, especially if we want to add support for more file types/drivers.

Contributor guide

Open the contributing guide

Research direction

Start in cat.py by reading CatalogFileDataReader and its current driver and file-type handling. Trace how the existing cases are selected, then define the abstraction needed to support additional file types and drivers; it is done when that handling is extensible without the current implementation's limitations.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.