instrumenta / instrumenta/kubeval

kubeval doesn't stop if job restartPolicy is wrong

Open
#259 7 comments 0 reactions 0 assignees View on GitHub
schema
Dominant language
Go
Stars
3.2k
Forks
227
PR merge metrics
No merged PRs in 30d

Description

We have some Job configuration and we expect `kubeval` to stop us if developers provide wrong settings. However, kubeval (0.15.0) simply ignored and at the final step we got an error with `helm upgrade`

```
Error: UPGRADE FAILED: failed to create resource: Job.batch "foo-tw-232-tre-two-worker-job" is invalid:
spec.template.spec.restartPolicy: Unsupported value: "Always": supported values: "OnFailure", "Never"
helm.go:84: [debug] Job.batch "foo-tw-232-tre-two-worker-job" is invalid:
spec.template.spec.restartPolicy: Unsupported value: "Always": supported values: "OnFailure", "Never"
failed to create resource
helm.sh/helm/v3/pkg/kube.(*Client).Update.func1
/home/circleci/helm.sh/helm/pkg/kube/client.go:190
helm.sh/helm/v3/pkg/kube.ResourceList.Visit
/home/circleci/helm.sh/helm/pkg/kube/resour
```

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.