instructure / instructure/once-ler

before/let from parent group can't resolve let_once'd item

Open
#8 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Ruby
Stars
22
Forks
6
PR merge metrics
No merged PRs in 30d

Description

this is due to how once-ler interleaves regular let/before's and once'd ones from the out in...

given:

describe MyClass
  before do
    puts foo.inspect
  end

  context "#lolwut" do
    let_once(:foo) { "yey a foo" }
    ...

the outer before runs before the inner foo has been replayed, so you'll just see nil. probably need to rethink how this all works 🤔

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the shown MyClass example with an outer before and an inner let_once(:foo), then trace how once-ler interleaves regular let/before hooks with once'd items. Done should ensure the parent before can resolve the inner let_once value rather than observing nil, with the behavior covered by a regression test.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby
Domain
testing
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.