instadeepai / instadeepai/winnow

fix: align InstaNovo tests with the default beam token log-probabilities prefix

Open Beginner friendly
#242 0 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
11
Forks
2
Avg merge
1d 8h
Merged PRs (30d)
1

Description

## Summary

`tests/datasets/data_loaders/test_instanovo.py` uses:

```python
"token_log_probabilities": "predictions_token_log_probabilities_"
```

The shipped config and real InstaNovo v1.2.2 output use:

```python
"token_log_probabilities": "predictions_token_log_probabilities_beam_"
```

The tests are internally consistent, so they pass without exercising the actual default convention.

## Change

- Update the standard loader fixture and its test data to use
`predictions_token_log_probabilities_beam_`.
- Add an assertion for the three prefixes shipped in
`winnow/configs/data_loader/instanovo.yaml`.
- Leave tests for custom beam-column prefixes unchanged.

This is test alignment only. No loader behaviour, schema, or defaults should change.

Contributor guide

Open the contributing guide

Research direction

Start with tests/datasets/data_loaders/test_instanovo.py and compare its standard loader fixture and test data with the three prefixes in winnow/configs/data_loader/instanovo.yaml. Run the InstaNovo test file; done means the standard data uses predictions_token_log_probabilities_beam_, all three shipped prefixes are asserted, and custom beam-column prefix tests remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
88/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.