instacart / instacart/truetime-android

_retryCount is never used?

Open
#97 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
1.5k
Forks
196
PR merge metrics
No merged PRs in 30d

Description

It seems there's a `withRetryCount` API in the `builder` but it doesn't seem to be used/supported?

https://github.com/instacart/truetime-android/blob/0630cdf3341b82c2fb16d0ff3e95c32c4ee1a78c/library-extension-rx/src/main/java/com/instacart/library/truetime/TrueTimeRx.java#L31

I was under the impression perhaps that this would provide retry behavior until we reach the max retry count until I looked at the source and realized there are no references to this variable anywhere.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at library-extension-rx/src/main/java/com/instacart/library/truetime/TrueTimeRx.java around the linked withRetryCount builder API, then search the repository for _retryCount and withRetryCount references. Trace the builder into the retry flow and verify with existing tests or the relevant entry point; done means the API's intended retry behavior is either supported and covered or the unused API is clearly removed or corrected.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.