instacart / instacart/truetime-android

TrueTimeRx initial in Application.onCreate(), where I should add clear() for this disposable?

Open
#108 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
Kotlin
Stars
1.5k
Forks
196
PR merge metrics
No merged PRs in 30d

Description

Regarding example, we got a `Disposable` at time `TrueTimeRx` initial in `Application.onCreate()`, it should be added in a `CompositeDisposable` like this:

`private CompositeDisposable disposables;`
`disposables.add(trueTimeRxDisposable)`

Problem is we don't have something like `onDestroy` in `Application` layer, so where and when I should call `disposables.clear()`?

Contributor guide

No contributing guide indexed for this repository

Research direction

The issue points to the example's TrueTimeRx initialization in Application.onCreate(); start there and review how the Disposable is placed in a CompositeDisposable. Resolve and document when disposables.clear() should run for the Application lifecycle, making the example's cleanup guidance explicit.

Written by the indexing model from the issue text.

Assessment

Tech stack
android, kotlin
Domain
mobile
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.