instacart / instacart/lore

XGboost estimator will throw error when multiple evaluation metrics are given

Open
#123 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
1.5k
Forks
128
PR merge metrics
No merged PRs in 30d

Description

In [xgboost scikit-learn fit API](https://xgboost.readthedocs.io/en/latest/python/python_api.html#xgboost.XGBRegressor.fit), the argument `eval_metric` can be a string for single metric or a list of string for multiple metrics. However, if we provide a list to the `eval_metric`, it will break the `fit` method in `lore.estimators.xgboost.base`. Specifically, in [this](https://github.com/instacart/lore/blob/master/lore/estimators/xgboost.py#L70) and [that](https://github.com/instacart/lore/blob/master/lore/estimators/xgboost.py#L74). Can we support multiple eval metrics? I can submit a PR to fix this. Thanks!

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.