instacart / instacart/TrueTime.swift
I am blocking the main thread and waiting sync till TrueTime responds. But it blocks forever!
Open
- Dominant language
- Swift
- Stars
- 634
- Forks
- 154
- PR merge metrics
- No merged PRs in 30d
Description
Hi!
I was blocking the main thread and waiting sync for TrueTime response. But it would forever wait!
Upon inspection, I realized that even though TrueTime code appears to be thread-safe, It is issuing some or all of its network calls on CFRunLoopGetMain().
It would seem to me to be better if it did not use the main thread to get its job done.
Thanks.
Regards.
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.