instacart / instacart/Snacks

Form validations type needs fixing.

Open
#371 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
82
Forks
36
PR merge metrics
No merged PRs in 30d

Description

Using any FormComponent in typescript with validations throws following type error.

> ... is missing the following properties from type 'Validations': contains, equals, isAlpha, isAlphanumeric, and 62 more.

The FormComponent.d.ts needs following change.

type Validations = **Partial<**{ [Key in keyof Validators]: ParametersAfterFirst }**>**

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.