FormComponent should use defaultProps
Open
- Dominant language
- JavaScript
- Stars
- 82
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
If an `id` prop is not passed to the `FormComponent` component, it generates a unique id for labels lower down in the component tree. This is great in some ways, but it has a couple issues:
- It's not clear in the documentation that this will happen, since it's not using `defaultProps`
- This causes issues with snapshot tests for users of the library, since this data is randomized for each test run
Issue 1 has an obvious fix. Issue 2 could just be a requirement for users to supply an id prop during tests.
Contributor guide
Assessment
This issue has not been assessed yet.