inspect-js / inspect-js/node-deep-equal

Some unit tests don't make sense

Open
#108 5 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
792
Forks
106
PR merge metrics
No merged PRs in 30d

Description

Trawling thru the unit tests, I've noticed some failed tests that I really think should pass.
For example:
`not ok 223 empty buffer and empty array are not equal`
I, would honestly expect and empty buffer and empty array to NOT be equal. One holds arbitrary data and one holds bytes. So why then, are them not being equal a fail?
Also:
`not ok 303 Date and RegExp are not equal`
I cannot see any scenario where a Date and a RegExp would be any type of equal, them being 2 completely different types with completely different intended functionality. So then why is them not being equal a failed test?

I want to adopt this library, but I need to ensure I won't have any... Surprises.

Can someone explain these test results and maybe convince me to integrate this library?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.