insightsengineering / insightsengineering/teal

Register bookmark exclusions

Open
#1,187 0 comments 0 reactions 0 assignees View on GitHub
core
Dominant language
R
Stars
263
Forks
59
Avg merge
5d 17h
Merged PRs (30d)
5

Description

Companion to https://github.com/insightsengineering/teal/pull/1011

As a rule, all buttons should be excluded from bookmarking. At the beginning of the module server function add `shiny::setBookmarkExclude(c("", ""))` to register exclusions. Note that consecutive calls to `setBookmarkExclude` overwrite the exclusion list so only the last one counts.

In theory some buttons should _not_ be excluded. Analyze the code and if the button server value (number of clicks) is used, do not exclude it.

Do this for all module repos:
- [x] `teal.modules.general`
- [ ] `teal.modules.clinical`
- [ ] `teal.modules.helios`
- [ ] `teal.modules.hermes`
- [ ] `teal.goshawk`
- [x] `teal.ospery`

`teal` and `teal` reporter are already modified on branch `898_save_app_state3@main`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.