insightsengineering / insightsengineering/teal.widgets

Confusing IDs in the download part of plot-with-settings

Open
#255 0 comments 0 reactions 0 assignees View on GitHub
core
Dominant language
R
Stars
6
Forks
8
PR merge metrics
No merged PRs in 30d

Description

In addition to https://github.com/insightsengineering/teal.widgets/issues/241

I have found confusing the approach of giving the IDs to the elements. Please find a few examples below:

- `#plot_with_settings-downbutton-downl`
- Why to put "download" twice?
- Why two distinct shortcuts for the "download" - here: "down" and "downl".
- Why to put the class "button" in the element ID?

- `#plot_with_settings-downbutton-data_download`
- (all of above)
- it downloads the _plot_ and it has nothing with the _data_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.