insightsengineering / insightsengineering/teal.widgets

Consistent naming ID for `type_download_ui` for `table_with_settings` and `plot_with_settings`

Open
#241 0 comments 0 reactions 1 assignee Claimed by @m7pr View on GitHub
core enhancement
Dominant language
R
Stars
6
Forks
8
PR merge metrics
No merged PRs in 30d

Description

### Feature description

Currently we have 2 similar widgets: `table_with_settings` and `plot_with_settings`. Both of them have similar structure of UI and share the same naming convention of namespaces, besides one place in `type_download_ui`

https://github.com/insightsengineering/teal.widgets/blob/3176ff54b7aef0e69528fad6dc4b6c51700c1539/R/plot_with_settings.R#L554
https://github.com/insightsengineering/teal.widgets/blob/3176ff54b7aef0e69528fad6dc4b6c51700c1539/R/table_with_settings.R#L139

Such discrepancy was caught during automated tests in https://github.com/insightsengineering/teal.widgets/pull/240

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.