insightsengineering / insightsengineering/teal.transform

dynamic filter_spec: no variable selected should mean no filtering, and not filter out all data

Open
#32 7 comments 0 reactions 0 assignees View on GitHub
core discussion
Dominant language
R
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

NEST/teal.devel/issues/716

currently:

![image](https://user-images.githubusercontent.com/12943682/128363657-b93a388b-384f-43e1-a240-c64c12642355.png)

Despite `SEX` being selected in the `select_spec` there is no faceting because `filter_spec` is not selected. Currently, if `filter_spec` is not selected then it filters out all data.

At the very least, I think that if the variable of the `filter_spec` is not selected, then it should behave as if the `filter_spec` was simply not provided, i.e. no filtering.

We should ask, are there cases where the user would want to filter out ALL data?
If not, then even in the case where the variable is not empty but the value is empty, it should also mean no filtering, and not filter out all like it does currently:

![image](https://user-images.githubusercontent.com/12943682/128363703-e49d84d7-2147-45aa-9a79-4534688e17aa.png)

Provenance:
```
Creator: junlue
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.