insightsengineering / insightsengineering/teal.transform

[Bug]: Forced merge precludes using modules without joinin keys

Open
#258 4 comments 1 reaction 0 assignees View on GitHub
bug core
Dominant language
R
Stars
2
Forks
3
PR merge metrics
No merged PRs in 30d

Description

### What happened?

Even in modules that treat datasets independently, `teal.transform` attempts to join them and fails if no keys are provided.

modified example app

```
library(teal)
library(teal.modules.general)

data <- teal_data()
data <- within(data, {
require(nestcolor)
USArrests <- USArrests
iris <- iris
})

app <- init(
data = data,
modules = modules(
tm_a_pca(
"PCA",
dat = list(
data_extract_spec(
dataname = "USArrests",
select = select_spec(
choices = variable_choices(
data = data[["USArrests"]], c("Murder", "Assault", "UrbanPop", "Rape")
),
selected = c("Murder", "Assault"),
multiple = TRUE
),
filter = NULL
),
data_extract_spec(
dataname = "iris",
select = select_spec(
choices = variable_choices(
data = data[["iris"]], function(data) names(Filter(is.numeric, data))
),
selected = NULL,
multiple = TRUE
),
filter = NULL
)
)
)
)
)
if (interactive()) {
shinyApp(app$ui, app$server)
}
```

![Image](https://github.com/user-attachments/assets/1e5fc6c1-8764-40d4-ade3-d651d025b829)

### sessionInfo()

```R
> packageVersion("teal.transform")
[1] ‘0.5.0’
> packageVersion("teal.modules.general")
[1] ‘0.3.0’
```

### Relevant log output

```R

```

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct.

### Contribution Guidelines

- [x] I agree to follow this project's Contribution Guidelines.

### Security Policy

- [x] I agree to follow this project's Security Policy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.