insightsengineering / insightsengineering/teal.picks

[Bug]: Unstable placement when pick button is at bottom of the encoding panel/window

Open
#91 0 comments 1 reaction 0 assignees View on GitHub
bug
Dominant language
R
Stars
4
Forks
0
Avg merge
6d 11h
Merged PRs (30d)
3

Description

### What happened?

Example with `teal_modules_clinical`'s binary_outcome module

https://github.com/user-attachments/assets/f0fa7099-0e0a-4e6f-a304-55f78361ba17

Current implementation:

1. Checks for `picks` position
2. Move popup DOM element to html body
3. Place it on current `picks` position calculated in 1. with X offset

Some topics to discuss:

- Is this just an implementation bug and requires better JS/CSS positioniong
- Should we detect that it will placed at bottom of window and just offset it "upwards" (possibily using `bottom` CSS property)
- Module in screencast has extra whitespace which might be a indicator that our strategy to keep popup hidden is failing

### Relevant log output

_No response_

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct.

### Contribution Guidelines

- [x] I agree to follow this project's Contribution Guidelines.

### Security Policy

- [x] I agree to follow this project's Security Policy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.