insightsengineering / insightsengineering/teal.modules.hermes
Update unit tests
- Dominant language
- R
- Stars
- 7
- Forks
- 1
- PR merge metrics
- No merged PRs in 30d
Description
### Feature description
Currently, `tm.hermes` uses snapshot tests (e.g., `.png`, `.md`) to verify the accuracy of the module, including content produced by `hermes`, the engine package behind it.
However, validating the content generated by `hermes` should not be part of `tm.hermes` unit tests. That validation belongs within the engine package itself.
Let’s follow this same principle when writing unit tests for `tm.hermes` and apply it consistently across our other modules.
### Acceptance Criteria
* Remove unit tests that is out of scope from tm.hermes (i.e. calculation result related tests)
* Unit tests should only focus on tm.hermes elements, consistent with what we've done on other teal modules packages.
### Code of Conduct
- [x] I agree to follow this project's Code of Conduct.
### Contribution Guidelines
- [x] I agree to follow this project's Contribution Guidelines.
### Security Policy
- [x] I agree to follow this project's Security Policy.
Contributor guide
Assessment
This issue has not been assessed yet.