insightsengineering / insightsengineering/teal.modules.general

[Question]: Duplicate code in tmg and teal.widgets

Open
#881 4 comments 2 reactions 0 assignees View on GitHub
core question
Dominant language
R
Stars
16
Forks
23
PR merge metrics
No merged PRs in 30d

Description

### What is your question?

The function `variable_type_icons` exists in two places:

tmg:
https://github.com/insightsengineering/teal.modules.general/blob/a835f3d70df7232977818ea576e282f54ade860c/R/utils.R#L237-L251

teal.widgets:
https://github.com/insightsengineering/teal.widgets/blob/d94641a1d7e532bef125e229cfc2407fd0d32d43/R/optionalInput.R#L323-L337

They're identical and I think they should live in `teal.widgets`.
Should we remove the one in tmg?

### Code of Conduct

- [x] I agree to follow this project's Code of Conduct.

### Contribution Guidelines

- [x] I agree to follow this project's Contribution Guidelines.

### Security Policy

- [x] I agree to follow this project's Security Policy.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.