insightsengineering / insightsengineering/teal.modules.clinical

replace assignment of adsl_filtered with parent_name

Open
#91 2 comments 0 reactions 0 assignees View on GitHub
sme
Dominant language
R
Stars
42
Forks
22
Avg merge
22m
Merged PRs (30d)
1

Description

Issue from comment here:
NEST/teal.modules.clinical/issues/592#issuecomment-61693

The `adsl_filtered` object should not be hardcoded to be named `adsl_filtered` but the name should be derived from `parent_name`, so that we could have object `bla_filtered` if `parent_name` is `bla`.

If this approach is used, then check all modules to stay consistent.

Provenance:
```
Creator: qit3
```

Contributor guide

Open the contributing guide

Research direction

Start by locating the assignment of the `adsl_filtered` object and trace how `parent_name` is passed into that module. Inspect the other modules for similar hardcoded filtered-object names. Done means the filtered name is derived from `parent_name` consistently across all modules.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.