insightsengineering / insightsengineering/teal.modules.clinical

Unused parameters in tm_g_lineplot(): need to specify the package source for g_lineplot()

Open
#613 3 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
R
Stars
42
Forks
22
Avg merge
22m
Merged PRs (30d)
1

Description

### What happened?

Getting error messages like "unused parameters in tm_g_lineplot()".

Possibly because:
Loaded both packages: goshawk and tern where both of them have a same function, g_lineplot(). It might call the g_lineplot in goshawk rather than the correct one, in tern.

Could we change line 129 in source code to _tern::g_lineplot()_ to avoid this kind of error (https://github.com/insightsengineering/teal.modules.clinical/blob/main/R/tm_g_lineplot.R)? Feel free to reach out for questions and thank you! :)

### sessionInfo()

_No response_

### Relevant log output

_No response_

### Code of Conduct

- [X] I agree to follow this project's Code of Conduct.

### Contribution Guidelines

- [X] I agree to follow this project's Contribution Guidelines.

### Security Policy

- [X] I agree to follow this project's Security Policy.

Contributor guide

Open the contributing guide

Research direction

Start with line 129 of R/tm_g_lineplot.R, where g_lineplot() is called, and inspect how the goshawk and tern functions can conflict. The issue is done when the call explicitly selects tern::g_lineplot() and the unused-parameter error is no longer reproduced.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.