insightsengineering / insightsengineering/teal.goshawk

Improve the add_straight_line module

Open
#85 6 comments 0 reactions 0 assignees View on GitHub
enhancement research
Dominant language
R
Stars
3
Forks
3
Avg merge
2d 6h
Merged PRs (30d)
11

Description

Currently the module for arbitrary lines takes to much space and is not user friendly.
![Screen Shot 2021-12-03 at 10 51 03](https://user-images.githubusercontent.com/6959016/144582936-e3b3c74b-b467-48e5-8107-97c0f85466eb.png)

My proposition is to reduce the space of the module and to have it more robust. Requirements of the implementation:
- The single arbitrary line attributes should be as small as possible to not take to much space.
- One should be able to add, modify and remove arbitrary lines one by one
- Each line added is shown in the encoding panel as a small bullet

# proposition 1 - popup window
To add the new line user clicks (+) button which triggers small window to pop, with inputs for value, color and label. After submitting small bullet describing the line stays in the encoding panel and new straight line is drawn on the plot. One can also remove (+) and modify (~) the line by clicking relevant buttons.

![teal goshawk add_lines (1)](https://user-images.githubusercontent.com/6959016/144587890-72e39607-daa8-4955-a740-690af3c73a9c.jpg)

# proposition 2 - collapsible div
To add the new line user clicks (+) which adds collapsible-div with inputs for value, color and label. In contrast to the option-1 these inputs does not disappear but they can be hidden by folding the div to the minimal size. Modifying the lines would require just unfolding div and clicking the inputs as usual. User can remove single line inputs by clicking (x)

![teal goshawk add_lines-collapsible box](https://user-images.githubusercontent.com/6959016/144589393-96fbb5cb-b62c-4cd4-9cb4-231206b310dd.jpg)

Design file
https://app.diagrams.net/#G12KVOtFwNMMgFsrjpRAgLtHpOr5wSd4JN

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.