insightsengineering / insightsengineering/teal.goshawk

Improve validation on modules (remove `shinyvalidate` dependency)

Open
#379 0 comments 0 reactions 0 assignees View on GitHub
core enhancement
Dominant language
R
Stars
3
Forks
3
Avg merge
2d 6h
Merged PRs (30d)
11

Description

It is true, indeed it is a long, harcoded validation that won't be easy to generalize and to remove. We might create an issue to refactor and leave it for later

_Originally posted by @osenan in https://github.com/insightsengineering/teal.goshawk/pull/378#discussion_r3803390372_

Contributor guide

Open the contributing guide

Research direction

No files or tests are named. Start by tracing validation in the modules and locating the shinyvalidate dependency, then determine how the current hardcoded validation is structured. Done should mean the validation is improved and shinyvalidate is no longer required, but the generalization scope needs clarification first.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
full-stack
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.