insightsengineering / insightsengineering/goshawk

hline/vline legend labels

Open
#91 0 comments 0 reactions 0 assignees View on GitHub
enhancement
Dominant language
R
Stars
5
Forks
1
PR merge metrics
No merged PRs in 30d

Description

in boxplot, as in other modules that handle one assay at a time, the range lines legend labels displays variable label.
in correlation plot where it handles two assays and thus the data requires pivoting, the legend only displays variable name.
![image](https://user-images.githubusercontent.com/40777373/149383588-5a8b6503-f0ce-4c97-8146-e924b5be02af.png)

the pivoted table columns do not have label attribute set.
![image](https://user-images.githubusercontent.com/40777373/149381826-981fa1ee-d834-4810-b77c-d25d9c683169.png)

consider the following
perhaps something like if LLOQ then
paste("Lower Limit of Quantitation:", xaxis_param)
paste("Lower Limit of Quantitation:", yaxis_param)
or if ULOQ
paste("Upper Limit of Quantitation:", , xaxis_param)
paste("Upper Limit of Quantitation:", , yaxis_param)

or
.would it be possible to label the LLOQ* and ULOQ* variables in the plot_data_2 table generically as "Lower Limit of Quantitation" and "Upper Limit of Quantitation" respectively and then since we have the PARAMCD value for the selected x-axis and y-axis to concatenate the two to create the legend label?
paste0(attributes(plot_data_t2$ARM)$label, ": ", xaxis_param)
etc.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.