insightsengineering / insightsengineering/crane

Extract anonymous formatting functions from add_grade_column()

Open
#251 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
R
Stars
15
Forks
7
Avg merge
1d 9h
Merged PRs (30d)
3

Description

The `modify_table_body()` call inside `add_grade_column()` uses anonymous functions for label formatting (grade labels, "Any Grade" rows, indent logic). These could be extracted into named internal helpers for reuse and testability.

Ref: review comment on #228.

Contributor guide

Open the contributing guide

Research direction

Start at the add_grade_column() entry point and inspect its modify_table_body() call, focusing on the anonymous functions for grade labels, "Any Grade" rows, and indentation. Trace nearby table-formatting code and existing tests if present; done means those behaviors are provided by named internal helpers without changing the output, with reusable helpers covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
r
Domain
data-visualization
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.