inrupt / inrupt/solid-client-js

Calling `getThing` with the IRI of a Blank Node throws Error

Open
#1,752 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug Triaged
Dominant language
TypeScript
Stars
245
Forks
42
Avg merge
12h 49m
Merged PRs (30d)
22

Description

Search terms you've used
  • Blank Node
Bug description

I was trying to iterate all things from a Dataset, but getThing throws an error if the subject URI is a Blank Node (_:example)

To Reproduce
  1. Declare a Solid resource resource with a thing Thing with a Blank Node as subject: _:Thing
  2. `const dataset = await getSolidDataset(resourceURI, {fetch})
  3. const thing = getThing(dataset, "_:Thing")
Expected result

A Thing with a Blank Node as subject URI and no errors.

Actual result

The following error:

  • Error: Expected a valid URL to identify a Thing, but received: [_:Thing].
Environment
$ npx envinfo --system --npmPackages --binaries --npmGlobalPackages --browsers
  System:
    OS: macOS 13.0
    CPU: (8) arm64 Apple M1 Pro
    Memory: 1.33 GB / 16.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.11.0 - /opt/homebrew/bin/node
    Yarn: 1.22.19 - /opt/homebrew/bin/yarn
    npm: 8.19.3 - ~/Documents/Profesional/Semantyk/Projects/Semantyk/client/node_modules/.bin/npm
  Browsers:
    Chrome: 107.0.5304.110
    Safari: 16.1
  npmPackages:
    @comunica/query-sparql-solid: ^2.3.0 => 2.3.0 
    @inrupt/solid-client: ^1.23.3 => 1.23.3 
    @inrupt/solid-ui-react: ^2.8.2 => 2.8.2 
    @inrupt/vocab-common-rdf: ^1.0.5 => 1.0.5 
    @react-three/drei: ^9.40.0 => 9.40.0 
    @react-three/fiber: ^8.9.1 => 8.9.1 
    @testing-library/jest-dom: ^5.16.5 => 5.16.5 
    @testing-library/react: ^13.4.0 => 13.4.0 
    @testing-library/user-event: ^14.4.3 => 14.4.3 
    bootstrap: ^5.2.2 => 5.2.2 
    lamina: ^1.1.23 => 1.1.23 
    node-fetch: ^3.2.10 => 3.2.10 
    npm: ^8.19.3 => 8.19.3 
    rdflib: ^2.2.20 => 2.2.20 
    react: ^18.2.0 => 18.2.0 
    react-bootstrap: ^2.5.0 => 2.5.0 
    react-dom: ^18.2.0 => 18.2.0 
    react-force-graph: ^1.41.15 => 1.41.15 
    react-helmet-async: ^1.3.0 => 1.3.0 
    react-router-dom: ^6.4.3 => 6.4.3 
    react-scripts: 5.0.1 => 5.0.1 
    stream-to-string: ^1.2.0 => 1.2.0 
    three: ^0.146.0 => 0.146.0 
    three-forcegraph: ^1.39.7 => 1.39.7 
    web-vitals: ^3.0.4 => 3.0.4 
  npmGlobalPackages:
    npm: 8.19.2

Additional information

  • I was trying to get all subjects from https://jeff-zucker.solidcommunity.net/sp4/glossary-data.ttl which has a few Blank Nodes as subjects

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the getThing entry point and reproduce the reported call with a dataset whose subject is _:Thing. Check how blank-node identifiers are handled, then verify that getThing returns a Thing without the reported URL error for blank-node subjects.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.