inrupt / inrupt/solid-client-authn-js
Make Session implement ISessionInfo
Open
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 77
- Forks
- 49
- Avg merge
- 18h 20m
- Merged PRs (30d)
- 32
Description
As discussed in https://github.com/inrupt/solid-client-authn-js/issues/567, we currently have an inconvenient session.info field.
I propose to:
- make
SessionimplementISessionInfoto avoid this detour - (optional) create an
ISessioninterface, which is whatSessionimplements - have
handleIncomingRedirectreturnSession(ISession) rather thanISessionInfo - deprecate
Session#infoso we can remove it in a future version - change all
ISessionInfoXxxclasses and interfaces to returnSession(ISession) instead ofISessionInfo- with the next semver.major release, rename those classes into
ISessionXxxinstead
- with the next semver.major release, rename those classes into
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the Session and ISessionInfo definitions, handleIncomingRedirect, and the ISessionInfoXxx classes and interfaces named in the issue. Trace how Session and session.info are exposed before deciding the interface and deprecation changes. Done means the checklist is addressed consistently, including the semver-major renames where applicable.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100