inrupt / inrupt/solid-client-authn-js

Should save to session storage. Not local storage

Open
#474 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
77
Forks
49
Avg merge
18h 20m
Merged PRs (30d)
32

Description

Again, this is leftover from my code. So, sorry about that.

Currently the library saves things like the code_verifier to localstorage. It should be session storage instead:

https://github.com/inrupt/solid-client-authn-js/blob/master/packages/browser/src/storage/BrowserStorage.ts#L34-L40

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in packages/browser/src/storage/BrowserStorage.ts at lines 34-40, where the issue identifies the current storage behavior. Change the relevant persistence from local storage to session storage, then verify that values such as code_verifier are stored and retrieved through session storage.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.