inrupt / inrupt/solid-client-authn-js
Remove Expiration from the DPoP token
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 77
- Forks
- 49
- Avg merge
- 18h 20m
- Merged PRs (30d)
- 32
Description
My mistake when I originally wrote this. DPoP tokens don't have expiration dates (https://tools.ietf.org/html/draft-fett-oauth-dpop-04#section-4.1). This line should be removed (https://github.com/inrupt/solid-client-authn-js/blob/bd83305b6a1e72c3662c19c680c59143620e7d9e/packages/oidc-dpop-client-browser/src/dpop/dpop.ts#L122)
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open packages/oidc-dpop-client-browser/src/dpop/dpop.ts at line 122 and read the surrounding DPoP token construction. Confirm the expiration handling is inconsistent with the referenced DPoP specification, then verify that the expiration is no longer included in the generated token.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100