inrupt / inrupt/solid-client-authn-js
Session#login could return a Promise resolving to redirectUrl (or an object containing it)
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 77
- Forks
- 49
- Avg merge
- 18h 20m
- Merged PRs (30d)
- 32
Description
Search terms you've used
login
Impacted environment
In which environment would the proposed feature apply ?
- The browser
- Node.js
- Other (please specify): ...
- I'm not sure.
Feature suggestion
Session#login could return a Promise resolving to the redirectUrl (or an object containing it), which gets passed to handleRedirect callback.
Actual functionality/enhancement
Currently Session#login returns Promise<void> which is not very useful.
Having the redirectUrl available once Promise resolves would make some of our code a little simpler. It would also simplify mocking the login in tests.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at Session#login and trace how its result reaches the handleRedirect callback described in the issue. Determine whether the resolved value should be redirectUrl or an object containing it, then verify that browser and Node.js behavior and the affected login mocks remain consistent. Done means the Promise exposes the redirect URL and existing login behavior still works.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- authentication
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100