inrupt / inrupt/solid-client-authn-js

handleIncomingRedirect() strips querystring from redirect_uri when restorePreviousSession : true

Open
#1,989 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
77
Forks
49
Avg merge
18h 20m
Merged PRs (30d)
32

Description

Search terms you've used

search: handleIncomingRedirect

Impacted package

Which packages do you think might be impacted by the bug ?

  • [x ] solid-client-authn-browser
Bug description

When using await session.handleIncomingRedirect({ restorePreviousSession : true }) after a refresh, the redirect_uri sent to the server to use in the redirect back is stripped of the query string, so the app will always end up logging in back at the start page for the app rather than the state represented by the query string.

To Reproduce
  1. Click refresh on browser
  2. Observer redirect_uri coming back stripped of query string
  3. Logs in back in start page for app
Expected result

The redirect_uri should be maintained with querystring through the silent log in process such that the app can continue where it was at the time of refresh using initial query state.

Actual result

query stripped from redirect_uri

Environment

App using above function communicating with Pod Server

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at handleIncomingRedirect in the solid-client-authn-browser package and reproduce the refresh flow with a query string in the current URL. Trace the silent login redirect_uri handling and verify that the query string is preserved so the app returns to its prior state.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.