inrupt / inrupt/solid-client-authn-js

Default OIDC Discovery values not set

Open
#1,734 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
TypeScript
Stars
77
Forks
49
Avg merge
18h 20m
Merged PRs (30d)
32

Description

Search terms you've used

oidc, openid, default

Impacted package

Which packages do you think might be impacted by the bug ?

  • solid-client-authn-browser
  • solid-client-authn-node
  • solid-client-authn-core
  • oidc-client-ext
  • Other (please specify): ...
Bug description

When loading the OIDC Discovery data from the .well-known/openid-configuration endpoint of an Identity Provider, the solid-client-authn-core package does not seem to add some defaults of the provider metadata.

To Reproduce
  1. Use a discovery configuration file with no grant_types_supported parameter.
  2. Try to log in using the solid-client-authn-browser package (not tested for solid-client-authn-node), with client credentials (other flows trigger Dynamic Registration, which does not check for the left-out parameter.)
Expected result

The AggregateOidcHandler succeeds in AuthorizationCodeWithPkceOidcHandler because the grant_types_supported parameter falls back to the default.

Actual result

The AggregateOidcHandler fails, because the AuthorizationCodeWithPkceOidcHandler returns false, since there is not grant_types_supported parameter set.

Additional information

The default value for the grant_types_supported parameter should be ["authorization_code", "implicit"]. Not sure which other defaults are missing.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing OIDC Discovery data through the solid-client-authn-core package into AggregateOidcHandler and AuthorizationCodeWithPkceOidcHandler. Compare the handled metadata with the OpenID Connect Provider Metadata defaults, then verify that a configuration without grant_types_supported allows the browser authorization-code-with-PKCE flow to succeed.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
authentication
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.