input-output-hk / input-output-hk/scrypto

Check or restore keys during sliced tree recovery

Open
#89 1 comment 0 reactions 1 assignee Claimed by @knizhnik View on GitHub
Bounty-500 SigUSD
Dominant language
Scala
Stars
203
Forks
49
PR merge metrics
No merged PRs in 30d

Description

Currently keys are stored during manifest and subtrees serialization in BatchAVLProverSerializer. However, they are not protected via collision-resistant hash function for internal nodes. Thus, currently verifier (calling verify() functions in BatchAVLProverManifest and BatchAVLProverSubtree) is blindly trusting the keys, which opens possibilities for adversaries.

So we need to whether avoid storing keys for internal nodes at all, or implement check (for subtrees, and for manifest(assuming bottom keys of subtrees are correct)).

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.