informalsystems / informalsystems/interchain

Transaction sizes can grow too large

Open
#5 1 comment 0 reactions 0 assignees View on GitHub
Dominant language
No language data
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Description

## Context

This issue is a continuation of https://github.com/informalsystems/hermes/issues/2993. That particular issue was closed since the packet was successfully cleared. We'd like to avoid this situations in the future, however. This will involve a cross-repository and cross-organizational effort, which I'll track here.

## Next steps

**After a discussion with the IBC-go team and SDK we remarked on the following:**

- The proposer likely bypassed the Tendermint-side check on the max size of this tx.
- Most likely, the solution would not live in IBC-go.
- Marko: we want multiple levels of protection:
- Tendermint shoulnd’t allow >1 MB tx in mempool.
- SDK either shoulnd’t allow >max_bytes part of their gRPC API. By default, 4MB. Should be validated in CheckTx.
- The limiter in the field should be module-specific (IBC-go).

**Action items:**
- Adi: Double-check that indeed the Tendermint-level protection on the TX size can be bypassed
- Jacob G: Check with CosmoStation validator ([who proposed the offending tx](https://www.mintscan.io/osmosis/txs/F506105FAB8A7D26D950043B732C935A2896733C7AEB695F729CDC0631963252)) to investigate if their Tendermint configuration was by design loose to allow such a large transaction to enter their mempool and the blockchain.

## Acceptance criteria

To close this issue, the following are necessary

- [x] identify culprit and causes for why this problem appeared
- see the two action items above & comments belove: it appears [that Tendermint-level protection on the TX size can be bypassed](https://github.com/informalsystems/interchain/issues/5#issuecomment-1378813361)
- [ ] identify next steps -- for example, engineering efforts or additional investigation, measures for future protection -- if any are needed by any team (SDK, Notional, IBC, Tendermint, Hermes)
- [ ] for each each team that has next steps identified, there is an open issue to track that work in the team's repo

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.