informalsystems / informalsystems/hermes

Improvement suggestions to the `conclude` module

Open
#2,017 2 comments 1 reaction 1 assignee Claimed by @seanchen1991 View on GitHub
Dominant language
Rust
Stars
505
Forks
399
PR merge metrics
No merged PRs in 30d

Description

## Summary

Some suggestions for improvements to the `conclude.rs` module, notably adding colors to the status types (red for `Error`, green for `Success`, etc.) as well as adding an `Info` status type.

## Problem Definition

While working on #2014, I found myself wanting to output terminal output that didn't fit neatly into either `Success` or `Error` status types. These would have been appropriate being displayed via something like `Output::info`. Would it be appropriate to add this as a status type?

Additionally, it would be nice to add colors to the terminal output, i.e. red for `Error` output and green for `Success` output (`Info` would be colored blue) in order to match the colors that the logs exhibit. This can be easily done with the [console](https://crates.io/crates/console) crate.

## Proposal

Add an `Info` status type to the `conclude` module, as well as add color styling to the status types.

## Acceptance Criteria

- [ ] Add `Info` status type
- [ ] Add color styling to status types

____

#### For Admin Use

- [x] Not duplicate issue
- [ ] Appropriate labels applied
- [ ] Appropriate milestone (priority) applied
- [x] Appropriate contributors tagged
- [x] Contributor assigned/self-assigned

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.