influxdata / influxdata/ui

Move LSP initialization and eventing to `FluxMonacoEditor`

Open
#5,844 0 comments 0 reactions 1 assignee Claimed by @rockstar View on GitHub
team/automation
Dominant language
TypeScript
Stars
117
Forks
51
Avg merge
2d 15h
Merged PRs (30d)
4

Description

The `FluxMonacoEditor` should be in charge of initializing the lsp, which means it would then know if the lsp is ready before instantiating the monaco editor. Right now, `src/languageSupport/languages/flux/lsp/monaco.flux.lsp` contains a side effect that initializes the lsp and exports a single function that allows the editor to hook into resources initialized by the side effect, regardless of whether the side effect has completed. The adjustment needs to be made so that we _know_ the lsp worker is ready to interface with _before_ the monaco editor is instantiated.

DOD:
- Flux monaco editor does not render until the lsp is ready to make a connection
- The buffer code becomes unnecessary (though removal is not a requirement of this patch)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.