influxdata / influxdata/ui

eslint warnings relating to useEffect hook dependencies in flows pages

Open
#5,580 0 comments 0 reactions 0 assignees View on GitHub
team/dumplings team/ui
Dominant language
TypeScript
Stars
117
Forks
51
Avg merge
2d 15h
Merged PRs (30d)
4

Description

This is a subset of issue https://github.com/influxdata/ui/issues/4815, which is being chunked into smaller, logical units so that it can be analyzed in greater detail by a few members of the team.

**Steps to reproduce:**
List the minimal actions needed to reproduce the behavior.
1. run `yarn eslint` in ui root directory
2. receive warnings from React hooks with missing dependencies in `writeData` directories

**Expected behavior:**
Eslint warnings for missing dependencies either do not exist, or (where appropriate) are suppressed.

**Actual behavior:**
Eslint warnings like the following, as shown in the attached file. `warning React Hook useEffect has a missing dependency: 'dispatch'. Either include it or remove the dependency array`

**Visual proof**
Sample of `eslint` log
![Image](https://user-images.githubusercontent.com/13280708/187272834-ddffa79c-2633-40c6-a40f-68eb8520a3ee.png)

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.