influxdata / influxdata/ui

Alerts: Notebook generated alerts are missing syntax for setting levels

Open
#2,994 0 comments 0 reactions 0 assignees View on GitHub
area/notebooks kind/bug team/automation team/ui team/unity
Dominant language
TypeScript
Stars
117
Forks
51
Avg merge
2d 15h
Merged PRs (30d)
4

Description

## About the bug

After seeing yesterday's UI changes making Alerting less visible from the navbar, I tried to recreate a deadman check/alert, that I've been using in preparing tests, through the Notebook feature.

**Steps to reproduce:**
List the minimal actions needed to reproduce the behavior.

1. Generate some test data through data > buckets > add data > line protocol
2. Create a new notebook
3. Use query builder to query/preview the test data
4. Add an alert action and define the criteria as when creating a Check in the Alerts section

**Expected behavior:**

Expected the criteria syntax builder to follow the same logical syntax that exists for checks.

**Actual behavior:**

The current Notebook alert syntax reads
"When _value_ is _in condition for_ : _time frame_ and stop checking after _time frame_ "
The "old style" Alert check syntax reads more like
"When _value_ is _in condition for_ : _time frame_ **then set status to _level_** and stop checking after _time frame_"

When the Notebook prepared alert is exported as a task and left to run, it generates status messages, however the level is always "OK". I've not been able to locate where I can reset this to a different level like "Crit"

**Visual Proof:**

__Notebook Alert__
![NotebookAlert01](https://user-images.githubusercontent.com/25881301/138454152-5b632d6e-4c87-4bf7-b90b-bd5add656588.png)

__Alert Check__
![OldStyleAlert01](https://user-images.githubusercontent.com/25881301/138454113-f44f8f7b-599b-4625-b6fa-b6908e514f0e.png)

__Notebook Alert History__
![NotebookAlertHistory01](https://user-images.githubusercontent.com/25881301/138454217-4867476b-5c17-4179-a4c6-eb2871ba125b.png)

__Updated Alert History with Oldstyle check__
![AlertHistoryWithOldStyle01](https://user-images.githubusercontent.com/25881301/138473753-97d4a10f-7edd-418e-8314-0418e74123b3.png)

## About your environment

**Environment info:**
Browser is Chrome 95 on Ubuntu 20.04.
Working with latest remocal.
Latest UI commit
```
commit 377a4dbb294e313b0c4bb58e6dcfdadd21452eec (HEAD -> cypress/check-expr, upstream/master, origin/master, origin/HEAD, master)
Author: David Kim
Date: Thu Oct 21 18:43:57 2021 -0400

```

**Logs:**
No logs needed.

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.