influxdata / influxdata/telegraf

postgresql_extensible: query.tagvalue is strangely a CSV rather than a TOML array

Open
#13,730 1 comment 0 reactions 0 assignees View on GitHub
feature request help wanted size/m
Dominant language
Go
Stars
17.8k
Forks
5.8k
Avg merge
1d 20h
Merged PRs (30d)
161

Description

### Use Case

When creating custom queries `tagvalue` is widely used to define result columns to be used as tag. Given that whole config file is a TOML syntax, use of CSV string format for `tagvalue` feels less natural than what TOML array would be.

### Expected behavior

Supporting 2 types for the same config param can be messy, so I propose deprecate `tagvalue` and introduce `tagvalues` parameter with array type.

### Actual behavior

`tagvalue` is a CSV string.

### Additional info

_No response_

Contributor guide

Open the contributing guide

Research direction

Start by locating the postgresql_extensible implementation and its configuration handling and tests. Review how the existing tagvalue CSV parameter is parsed, then determine the compatibility and deprecation behavior for a new tagvalues TOML array; done means the new parameter works and the existing behavior is addressed consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, postgresql
Domain
databases
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.