influxdata / influxdata/pkg-config

Ensure the wrapper doesn't detect itself for the pkg-config binary

Open
#41 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
4
Forks
8
PR merge metrics
No merged PRs in 30d

Description

In a situation where the wrapper detects itself as the system pkg-config binary, it can call itself recursively. This ultimately causes the build to fail while also eating all your system resources in the process!

When searching for the system binary, we should check to make sure we haven't just rediscovered the wrapper. I'm not sure what the method for this should be. Perhaps we can canonicalize the paths, or generate hashes for each binary or something else.

If we exhaust our search only finding the wrapper then exit after printing some helpful message.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files or tests are named. Start by locating the wrapper's search for the system pkg-config binary and trace how a discovered candidate is invoked. Done means the wrapper is excluded from candidates and an exhausted search prints a helpful message instead of recursing.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
build-system, cli, tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.