influxdata / influxdata/pbjson
Implement visit_seq too?
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 116
- Forks
- 55
- PR merge metrics
- No merged PRs in 30d
Description
Currently, the Deserializer impls generated by pbjson can't be used with bincode, because bincode uses visit_seq and pbjson only implements visit_map.
Now, this is pbJSON, and serde_json only uses visit_map, so that's definitely an argument for not generating visit_seq in this crate.
However, implementing it here would make the generated impls arguably more correct, make them more flexible, and be in line with serde recommendations.
Are there any reasons visit_seq can't be implemented?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pbjson-build/src/generator/message.rs around line 520 and review how generated Deserializer implementations currently provide visit_map. Compare the bincode and serde deserialization expectations cited in the issue, then determine whether visit_seq can be supported without breaking JSON behavior. Done requires a documented compatibility decision and, if feasible, generated implementations with appropriate coverage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100